Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Waffle config watcher #481

Merged
merged 3 commits into from
Oct 27, 2023
Merged

feat: Add Waffle config watcher #481

merged 3 commits into from
Oct 27, 2023

Conversation

timmc-edx
Copy link
Member

@timmc-edx timmc-edx commented Oct 23, 2023

Listens to Waffle model changes and reports them 1) to the log and 2) to a Slack webhook.

This adds a dependency on django-waffle.


To test this in devstack:

  • Check out the branch under src, e.g. git worktree add ../src/edxarch-waffle/ timmc/waffle-watcher
  • In lms-shell: pip install -e /edx/src/edxarch-waffle/
  • In edx-platform's lms/envs/common.py, add 'edx_arch_experiments.config_watcher' to INSTALLED_APPS
  • Log in to LMS as the edx user
  • Change, add, or delete a Waffle flag, switch, or sample
  • Watch for the log message

You can also configure CONFIG_WATCHER_SLACK_WEBHOOK_URL to a request bin to confirm the request format.


Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@timmc-edx timmc-edx changed the title feat: Preliminary version of Waffle config watcher feat: Add Waffle config watcher Oct 23, 2023
@timmc-edx timmc-edx changed the base branch from rsgraber/20231023-innovation-week-settings-to-slack to main October 23, 2023 18:25
Listens to Waffle model changes and reports them 1) to the log and 2) to
a Slack webhook.

This adds a dependency on django-waffle.
@timmc-edx timmc-edx merged commit 25887c7 into main Oct 27, 2023
5 checks passed
@timmc-edx timmc-edx deleted the timmc/waffle-watcher branch October 27, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants